Skip to content

Add terminate ingest processor #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2024
Merged

Add terminate ingest processor #3003

merged 5 commits into from
Oct 10, 2024

Conversation

@PeteGillinElastic
Copy link
Member

@PeteGillinElastic PeteGillinElastic commented Oct 10, 2024

Adds terminate to the ingest processor spec.

Closes elastic/elasticsearch#110218

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_pipeline 🟢 59/59 59/59
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_pipeline 🟢 59/59 59/59
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@PeteGillinElastic PeteGillinElastic marked this pull request as ready for review October 10, 2024 09:39
@PeteGillinElastic PeteGillinElastic mentioned this pull request Oct 10, 2024
Closed
pquentin
pquentin reviewed Oct 10, 2024
View reviewed changes
specification/ingest/_types/Processors.ts
/**
* Terminates the current ingest pipeline, causing no further processors to be run.
* This will normally be executed conditionally, using the `if` option.
* @doc_id terminate-processor
Copy link
Member

@pquentin pquentin Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please a corresponding link in specification/_doc_ids/table.csv?

Copy link
Member Author

@PeteGillinElastic PeteGillinElastic Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_pipeline 🟢 59/59 59/59
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_pipeline 🟢 59/59 59/59
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@PeteGillinElastic PeteGillinElastic mentioned this pull request Oct 10, 2024
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_pipeline 🟢 59/59 59/59
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

dakrone
dakrone approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeteGillinElastic
Copy link
Member Author

PeteGillinElastic commented Oct 10, 2024

@pquentin Any other comments before I merge this?

flobernd
flobernd approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PeteGillinElastic PeteGillinElastic merged commit bcfdc95 into main Oct 10, 2024
6 checks passed
@PeteGillinElastic PeteGillinElastic deleted the fix/110218 branch October 10, 2024 19:25
github-actions bot pushed a commit that referenced this pull request Oct 10, 2024
@PeteGillinElastic @github-actions
Add terminate ingest processor (#3003)
9fb8049 
(cherry picked from commit bcfdc95)
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Merged
pquentin added a commit that referenced this pull request Oct 11, 2024
@github-actions @PeteGillinElastic @pquentin
[Backport 8.x] Add terminate ingest processor (#3009)
a1e3919 
* Add `terminate` ingest processor (#3003)

(cherry picked from commit bcfdc95)

* Run make contrib

---------

Co-authored-by: Pete Gillin <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakrone dakrone dakrone approved these changes

@flobernd flobernd flobernd approved these changes

@pquentin pquentin Awaiting requested review from pquentin

Assignees

No one assigned

Labels

backport 8.19 specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ingest node: terminate processor

5 participants

@PeteGillinElastic @dakrone @pquentin @flobernd